Improve running codelens commands in a split #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, running an LSP code lens command would open a new split and terminal emulator each time a command was run. This change allows us to reuse an open window and reuse a scratch buffer. It turns out that doing this kind of window managment requires a fair bit of intervention, so we introduce a `util` module to abstract some of the more complicated or frequent bits. One potential problem with this is that running concurrent code lens command would cause their outputs to overwrite each other. We can consider making this use plenary.job in the future Remove vestigial check for valid buffer when reporting job failure
|
This looks good. Indeed, it's a lot more code but it looks OK. Let's try it. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, running an LSP code lens command would open a new split and terminal emulator each time a command was run. This change allows us to reuse an open window and reuse a scratch buffer.
It turns out that doing this kind of window management requires a fair bit of intervention, so we introduce a
utilmodule to abstract some of the more complicated or frequently-used bits. This ended up being more code that I expected, but it seems to be a pretty robust solution. I'm happy to investigate another approach if I'm way off base.One potential (possibly imaginary) problem with this is that running concurrent code lens command would cause their outputs to overwrite each other. We can revisit this, and consider using plenary.job in the future.