Séparation des actions de TechLetter dans plusieurs classes

app/config/routing/techletter_admin.yml

@@ -1,30 +1,30 @@
 admin_techletter_generate:
   path: /generate/{techletterId}
-  defaults: {_controller: AppBundle\Controller\Admin\TechLetter\TechLetterGenerateController::generate}
+  defaults: {_controller: AppBundle\Controller\Admin\TechLetter\GenerateAction}
   requirements:
     techletterId: '\d+'
 
 admin_techletter_preview:
   path: /preview
-  defaults: {_controller: AppBundle\Controller\Admin\TechLetter\TechLetterGenerateController::preview}
+  defaults: {_controller: AppBundle\Controller\Admin\TechLetter\PreviewAction}
 
 admin_techletter_send_test:
   path: /send_test
-  defaults: {_controller: AppBundle\Controller\Admin\TechLetter\TechLetterGenerateController::sendTest}
+  defaults: {_controller: AppBundle\Controller\Admin\TechLetter\SendTestAction}
 
 admin_techletter_retrieve:
   path: /retrieve
-  defaults: {_controller: AppBundle\Controller\Admin\TechLetter\TechLetterGenerateController::retrieveData}
+  defaults: {_controller: AppBundle\Controller\Admin\TechLetter\RetrieveDataAction}
   methods: ["POST"]
 
 admin_techletter_index:
   path: /
-  defaults: {_controller: AppBundle\Controller\Admin\TechLetter\TechLetterGenerateController::index}
+  defaults: {_controller: AppBundle\Controller\Admin\TechLetter\IndexAction}
 
 admin_techletter_history:
   path: /history
-  defaults: {_controller: AppBundle\Controller\Admin\TechLetter\TechLetterGenerateController::history}
+  defaults: {_controller: AppBundle\Controller\Admin\TechLetter\HistoryAction}
 
 admin_techletter_members:
   path: /members
-  defaults: {_controller: AppBundle\Controller\Admin\TechLetter\TechLetterGenerateController::members}
+  defaults: {_controller: AppBundle\Controller\Admin\TechLetter\MembersAction}

app/config/services.yml

@@ -190,15 +190,6 @@ services:
         arguments:
             $backOfficePages: '%app.pages_backoffice%'
 
-    AppBundle\Controller\Admin\TechLetter\TechLetterGenerateController:
-        autowire: true
-        autoconfigure: true
-        public: false
-        arguments:
-            $mailchimp: '@app.mailchimp_techletter_api'
-            $techletterTestEmailAddress: '%techletter_test_email_address%'
-            $mailchimpTechletterList: '%mailchimp_techletter_list%'
-
     AppBundle\Mailchimp\Runner:
         autowire: true
         arguments:

sources/AppBundle/Controller/Admin/TechLetter/GenerateAction.php

@@ -0,0 +1,117 @@
+<?php
+
+declare(strict_types=1);
+
+namespace AppBundle\Controller\Admin\TechLetter;
+
+use AppBundle\Mailchimp\Mailchimp;
+use AppBundle\TechLetter\Model\Repository\SendingRepository;
+use AppBundle\TechLetter\Model\TechLetterFactory;
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\DependencyInjection\Attribute\Autowire;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+
+final class GenerateAction extends AbstractController
+{
+    public function __construct(
+        private readonly SendingRepository $sendingRepository,
+        #[Autowire('@app.mailchimp_techletter_api')]
+        private readonly Mailchimp $mailchimp,
+        private readonly TechLetterFactory $techLetterFactory,
+        #[Autowire('%mailchimp_techletter_list%')]
+        private readonly string $mailchimpTechletterList,
+    ) {}
+
+    public function __invoke($techletterId, Request $request): Response
+    {
+        $sending = $this->sendingRepository->get($techletterId);
+        if ($sending === null) {
+            throw $this->createNotFoundException('Could not find this techletter');
+        }
+        if ($sending->getSentToMailchimp() === true) {
+            throw $this->createAccessDeniedException('You cannot edit a sent techletter');
+        }
+
+        $techLetter = $this->techLetterFactory->createTechLetterFromJson($sending->getTechletter());
+
+        // Save the date
+        if ($request->getMethod() === Request::METHOD_POST
+            && $this->isCsrfTokenValid('techletterDate', $request->request->get('_csrf_token'))) {
+            $sending->setSendingDate(new \DateTime($request->request->get('sendingDate')));
+            $this->sendingRepository->save($sending);
+            $this->addFlash('notice', 'Date mise à jour');
+
+            return $this->redirectToRoute('admin_techletter_generate', ['techletterId' => $techletterId]);
+        }
+
+        if (
+            $request->getMethod() === Request::METHOD_POST &&
+            ($this->isCsrfTokenValid('sendToMailchimp', $request->request->get('_csrf_token')) ||
+                $this->isCsrfTokenValid('sendToMailchimpAndSchedule', $request->request->get('_csrf_token')))
+        ) {
+            // Ne pas planifier l'envoi dans le passé
+            $limitDatetime = new \DateTime('+5 min');
+            if ($sending->getSendingDate() < $limitDatetime) {
+                $sending->setSendingDate($limitDatetime);
+            }
+
+            $mailContent = $this
+                ->render(
+                    'admin/techletter/mail_template.html.twig',
+                    [
+                        'tech_letter' => $techLetter,
+                        'preview' => false,
+                    ],
+                )
+                ->getContent();
+
+            $subject = sprintf("Veille de l'AFUP du %s", $sending->getSendingDate()->format('d/m/Y'));
+
+            $template = $this->mailchimp->createTemplate($subject . ' - Template', $mailContent);
+
+            $response = $this->mailchimp->createCampaign(
+                $this->mailchimpTechletterList,
+                [
+                    'template_id' => $template['id'],
+                    'from_name' => "Pôle Veille de l'AFUP",
+                    'reply_to' => '[email protected]',
+                    'subject_line' => $subject,
+                ],
+            );
+
+            if ($this->isCsrfTokenValid('sendToMailchimpAndSchedule', $request->request->get('_csrf_token'))) {
+                try {
+                    $this->mailchimp->scheduleCampaign($response['id'], $sending->getSendingDate());
+                    $message = sprintf("Newsletter envoyée, verrouillée et planifiée pour être envoyée à %s (%s) sur Mailchimp",
+                        $sending->getSendingDate()->format('d/m/Y H:i'),
+                        $sending->getSendingDate()->getTimezone()->getName(),
+                    );
+                    $this->addFlash('notice', $message);
+                } catch (\Exception $exception) {
+                    $error = json_decode($exception->getMessage(), false);
+                    $message = sprintf('Erreur Mailchimp: "%s" (%s). La campagne a été générée.', $error->title, $error->detail);
+                    $this->addFlash('error', $message);
+                }
+            } else {
+                $message = "La campagne a été générée. Il faut maintenant <a href='https://us8.admin.mailchimp.com/campaigns/edit?id=" . $response['web_id'] . "' target='_blank'>se connecter sur Mailchimp</a> pour la valider/en planifier l'envoi";
+                $this->addFlash('notice', $message);
+            }
+
+            $sending->setArchiveUrl($response['long_archive_url']);
+            $sending->setSentToMailchimp(true);
+            $this->sendingRepository->save($sending);
+
+            return $this->redirectToRoute('admin_techletter_index');
+        }
+
+        return $this->render(
+            'admin/techletter/generate.html.twig',
+            [
+                'title' => "Veille de l'AFUP",
+                'sending' => $sending,
+                'tech_letter' => $techLetter,
+            ],
+        );
+    }
+}

sources/AppBundle/Controller/Admin/TechLetter/HistoryAction.php

@@ -0,0 +1,70 @@
+<?php
+
+declare(strict_types=1);
+
+namespace AppBundle\Controller\Admin\TechLetter;
+
+use AppBundle\TechLetter\Model\News;
+use AppBundle\TechLetter\Model\Repository\SendingRepository;
+use AppBundle\TechLetter\Model\TechLetterFactory;
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\HttpFoundation\Response;
+
+final class HistoryAction extends AbstractController
+{
+    public function __construct(
+        private readonly SendingRepository $sendingRepository,
+        private readonly TechLetterFactory $techLetterFactory,
+    ) {}
+
+    public function __invoke(): Response
+    {
+        $history = [];
+        foreach ($this->sendingRepository->getAll() as $sending) {
+            $defaultColumns = [
+                'date' => $sending->getSendingDate(),
+            ];
+
+            $techLetter = $this->techLetterFactory->createTechLetterFromJson($sending->getTechletter());
+
+            if (($firstNews = $techLetter->getFirstNews()) instanceof News) {
+                $url = $firstNews->getUrl();
+                $history[] = $defaultColumns + [
+                    'type' => 'First news',
+                    'url' => $url,
+                    'title' => $firstNews->getTitle(),
+                ];
+            }
+
+            if (($secondNewsNews = $techLetter->getSecondNews()) instanceof News) {
+                $url = $secondNewsNews->getUrl();
+                $history[] = $defaultColumns + [
+                    'type' => 'second news',
+                    'url' => $url,
+                    'title' => $secondNewsNews->getTitle(),
+                ];
+            }
+
+            foreach ($techLetter->getArticles() as $article) {
+                $history[] = $defaultColumns + [
+                    'type' => 'article',
+                    'url' => $article->getUrl(),
+                    'title' => $article->getTitle(),
+                ];
+            }
+
+            foreach ($techLetter->getProjects() as $project) {
+                $history[] = $defaultColumns + [
+                    'type' => 'project',
+                    'url' => $project->getUrl(),
+                    'title' => $project->getName(),
+                ];
+            }
+        }
+
+        return $this->render('admin/techletter/history.html.twig', [
+            'title' => "Veille de l'AFUP",
+            'history' => $history,
+        ]);
+    }
+}

sources/AppBundle/Controller/Admin/TechLetter/IndexAction.php

@@ -0,0 +1,40 @@
+<?php
+
+declare(strict_types=1);
+
+namespace AppBundle\Controller\Admin\TechLetter;
+
+use AppBundle\TechLetter\Form\SendingType;
+use AppBundle\TechLetter\Model\Repository\SendingRepository;
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+
+final class IndexAction extends AbstractController
+{
+    public function __construct(
+        private readonly SendingRepository $sendingRepository,
+    ) {}
+
+    public function __invoke(Request $request): Response
+    {
+        $techLetters = $this->sendingRepository->getAllOrderedByDateDesc();
+        $form = $this->createForm(SendingType::class);
+        $form->handleRequest($request);
+
+        if ($form->isSubmitted() && $form->isValid()) {
+            $techletter = $form->getData();
+            $this->sendingRepository->save($techletter);
+
+            return $this->redirectToRoute('admin_techletter_generate', [
+                'techletterId' => $techletter->getId(),
+            ]);
+        }
+
+        return $this->render('admin/techletter/index.html.twig', [
+            'title' => "Veille de l'AFUP",
+            'techletters' => $techLetters,
+            'form' => $form->createView(),
+        ]);
+    }
+}

sources/AppBundle/Controller/Admin/TechLetter/MembersAction.php

@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace AppBundle\Controller\Admin\TechLetter;
+
+use AppBundle\Association\Model\Repository\TechletterSubscriptionsRepository;
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\HttpFoundation\Response;
+
+final class MembersAction extends AbstractController
+{
+    public function __construct(
+        private readonly TechletterSubscriptionsRepository $techletterSubscriptionsRepository,
+    ) {}
+
+    public function __invoke(): Response
+    {
+        $subscribers = $this->techletterSubscriptionsRepository->getAllSubscriptionsWithUser();
+        return $this->render('admin/techletter/members.html.twig', [
+            'subscribers' => $subscribers,
+            'title' => 'Liste des abonnés à la techletter',
+        ]);
+    }
+}

sources/AppBundle/Controller/Admin/TechLetter/PreviewAction.php

@@ -0,0 +1,45 @@
+<?php
+
+declare(strict_types=1);
+
+namespace AppBundle\Controller\Admin\TechLetter;
+
+use AppBundle\TechLetter\Model\Repository\SendingRepository;
+use AppBundle\TechLetter\Model\TechLetterFactory;
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+
+final class PreviewAction extends AbstractController
+{
+    public function __construct(
+        private readonly SendingRepository $sendingRepository,
+        private readonly TechLetterFactory $techLetterFactory,
+    ) {}
+
+    public function __invoke(Request $request): Response
+    {
+        $sendingId = $request->request->getInt('techletterId');
+        $sending = $this->sendingRepository->get($sendingId);
+
+        if ($sending === null) {
+            throw $this->createNotFoundException('Could not find this techletter');
+        }
+        if ($sending->getSentToMailchimp() === true) {
+            throw $this->createAccessDeniedException('You cannot edit a sent techletter');
+        }
+        if ($this->isCsrfTokenValid('techletterPreview', $request->request->get('_csrf_token')) === false) {
+            throw $this->createAccessDeniedException('You cannot edit this techletter');
+        }
+
+        $techletter = $this->techLetterFactory->createTechLetterFromJson($request->request->get('techletter'));
+        // @todo could be better elsewhere
+        $sending->setTechletter(json_encode($techletter->jsonSerialize()));
+        $this->sendingRepository->save($sending);
+
+        return $this->render('admin/techletter/mail_template.html.twig', [
+            'preview' => true,
+            'tech_letter' => $techletter,
+        ]);
+    }
+}

sources/AppBundle/Controller/Admin/TechLetter/RetrieveDataAction.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+namespace AppBundle\Controller\Admin\TechLetter;
+
+use AppBundle\TechLetter\DataExtractor;
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\HttpFoundation\JsonResponse;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
+
+final class RetrieveDataAction extends AbstractController
+{
+    public function __invoke(Request $request): JsonResponse
+    {
+        $url = $request->request->get('url');
+        if ($url === null) {
+            throw new BadRequestHttpException('Undefined url parameter');
+        }
+
+        $dataExtractor = new DataExtractor();
+        $data = $dataExtractor->extractDataForTechLetter($url);
+
+        return new JsonResponse($data);
+    }
+}