[pull] master from devicekit:master #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serve the logo from rawgit.com
adds a danger file with a basic set of rules + running swiftlint
state the source of the identifiers in the readme
* add support for the 10.5 inch iPad Pro state the source of the identifiers in the readme * add support for iPad 5 and iPad Pro 12.9 inch gen 2
improve test coverage
…uild phase and declare the Device.generated.swift as the output file (as suggested in radar://problems/33202338)
Added known ppi values for applicable devices. Unit test added and verified with the devices public information in WikiPedia. Applicable devices are all devices that include a screen, so basically all the iPhones and Ipads. Unaplicable devices are devices whose screen is not part of the device itself, such as the AppleTV and the Simulators.
Fixed contributor's list is in Alphabetical order.
Added iPhone 8, 8+, X
remove `UserInterfaceIdiom` since it wasn't used, this is a non-breaking change because the enum had a private initializer (and I hope nobody extended it :)) fix documentation typos and spaces
* Add changelog entry for 5.2.1. * Version bump. (v5.2.1)
* fixes macOS build * Use description instead of safeDescription inside description. * Version bump (v5.2.2) --------- Co-authored-by: Honghao Zhang <[email protected]>
* Fix compile errors on visionOS. # Conflicts: # Source/Device.generated.swift # Source/Device.swift.gyb * Remove references to xrOS that are no longer applicable. * Add TODO comments in code about visionOS proper implementation. * Update changelog. --------- Co-authored-by: Chris Vasselli <[email protected]>
Co-authored-by: RayJiang <[email protected]>
* Fix ruby version for Danger not found. * Update ruby for Danger to 2.7.8. * Also update ruby for XCTests jobs to 2.7.8
* Initial implementation of support for new May 2024 devices. * Update Apple Pencil support. * Update iPad device names and device identifiers. * Rename new iPads enum values. * Fix line inset. * Fix tests after new devices added. * Add changelog. * Update changelog about extra ApplePencilSupport.
* Initial support for iPhone 16 models and Apple Watch Series 10. * Version bump. (v5.5.0) * Add missing device identifiers for new September 2024 devices. * Fix unit tests after adding new devices.
* ppi fixes as per apple tech specs iPhone 14 Plus, iPhone 15 Plus * Define PPI for iPhone 14/15 Plus in gyb file. --------- Co-authored-by: Zandor Smith <[email protected]>
* Fix CI after macOS 12 image deprecation by GitHub. * Increase minimum deployment target to iOS 13. * Select Xcode latest stable.
* Add support for iPad Mini (A17 Pro) * Update changelog. * Version bump. (v5.6.0)
* Add support for iPhone 16e. * Update changelog. * Add support for iPad (A16), iPad Air 11-inch (M3), iPad Air 13-inch (M3) * Updated GitHub actions. * Actions: Use macos-14 image instead of arm image.
…th version 5.7.0 release (#452) * Initial plan * Add iPhone 17 series and Apple Watch Ultra 3/Series 11 to Device.swift.gyb template * Fix Apple Watch Ultra 3 and Series 11 to use S10 chip instead of S11 * Add changelog entry for 5.7.0 and update version numbers - Add changelog entry for version 5.7.0 with September 12th release date - Include table of new iPhone 17 series and Apple Watch devices - Update version to 5.7.0 in README.md, DeviceKit.podspec, and project.pbxproj - Follow pattern from previous version releases * Fix changelog. * Build generated file after copilot gyb implementation. * Make iPhone Air plus sized. * More device attribute fixes. * Update tests after adding new devices. * Add changelog entry for Series 9 fix. --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Zandor300 <[email protected]>
…nt workflow (#454) * Initial plan * Add comprehensive .github/copilot-instructions.md with validated workflows Co-authored-by: Zandor300 <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Zandor300 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
41 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )