Fixed minor changes, that resulted in code crash during runtime #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush-me
approved these changes
Apr 16, 2020
Owner
ankush-me
left a comment
ankush-me
left a comment
There was a problem hiding this comment.
Thanks for the pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faced the following errors, while running the files. After making these minor changes, the code runs smoothly
Removed all instances of plt.hold(true) since the same has been deprecated.
Source : https://stackoverflow.com/questions/53689386/python-3-pyplot-hold-is-deprecated
cv2.find_contours() : return type expected values are 3, or 2 depending on the version of cv2 installed. Changed code to handle all versions.
Source : ValueError: not enough values to unpack (expected 3, got 2) facebookresearch/maskrcnn-benchmark#339