Fix extra-args handling #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code doesn't actually pass the extra args to nox. The action echos the command about to be run before running it, and ansible-community#6 only updates the `echo` part, not the actual command being run. Also, it would be good to also pass the args when installing the session dependencies as some sessions may make decisions about what to install based on the arguments passed (I've written code like this before, at least). Fixes: ansible-community#6
gotmax23
force-pushed
the
fix-extra-args
branch
from
8901a86 to
fcc7666
Compare
gotmax23
force-pushed
the
fix-extra-args
branch
from
fcc7666 to
8bec09d
Compare
felixfontein
approved these changes
Nov 10, 2025
Collaborator
|
@gotmax23 thanks for spotting and fixing this! |
Contributor
|
@gotmax23 Good catch, and thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code doesn't actually pass the extra args to nox. The action echos the command about to be run before running it, and #6 only updates the
echopart, not the actual command being run.Also, it would be good to also pass the args when installing the session dependencies as some sessions may make decisions about what to install based on the arguments passed (I've written nox sessions before that does this, but it's probably not super common).
Fixes: #6