Skip to content

Conversation

dabla
Copy link
Contributor

@dabla dabla commented Oct 10, 2025

After the move of macros to the Task SDK, the babel dependency is missing. This is probably due to the fact that in the past, the babel dependency was available through the flask-babel dependency. This PR add the babel dependency to the Task SDK so that macro's depending on it can work again.

closes: #56552


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@kaxil kaxil added this to the Airflow 3.1.1 milestone Oct 11, 2025
@kaxil
Copy link
Member

kaxil commented Oct 11, 2025

huh Task SDK tests didn't run. Need to probably update the selective checks.

@kaxil kaxil added the full tests needed We need to run full set of tests for this PR to merge label Oct 11, 2025
@hussein-awala hussein-awala reopened this Oct 11, 2025
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From your issue:

Use the macros.ds_format_locale in your jinja expressions and you will get an ModuleNotFoundError: No module named 'babel' error.

Could you create a unit test to reproduce the issue and ensure it's fixed by this change?

@dabla
Copy link
Contributor Author

dabla commented Oct 11, 2025

From your issue:

Use the macros.ds_format_locale in your jinja expressions and you will get an ModuleNotFoundError: No module named 'babel' error.

Could you create a unit test to reproduce the issue and ensure it's fixed by this change?

Normally there was an existing unit test for this before the move if I remember correctly, maybe I got removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdk full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Babel dependency is missing since macros have been moved into Task SDK

3 participants