Fix crash and add new feature #136
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Should this return 0? Perhaps the null result can be converted to JSONObject.NULL in lastModifiedDateForCursor() to avoid special return values.
janpio
requested changes
Jul 3, 2019
Member
janpio
left a comment
janpio
left a comment
There was a problem hiding this comment.
How can one trigger this crash with the lastmodified?
Also, we should probably split the feature into its own PR. It looks good, so this is definitely worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1- Fix crash when modified date is null (NullPointerException)
2- Added mime-type to Metadata (in Android when Content filesystem is used is the only way to know which file type is being handled.