-
Notifications
You must be signed in to change notification settings - Fork 669
Prepare for 0.40.0 release, derive 0.2.0 release
#1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Prepare for 0.40.0 release, derive 0.2.0 release
- Loading branch information
commit cc4f1cc8e411972b42670f8d7a6c1666cc907753
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,25 +6,30 @@ use syn::{ | |
| Ident, Index, Lit, Meta, MetaNameValue, NestedMeta, | ||
| }; | ||
|
|
||
|
|
||
| /// Implementation of `[#derive(Visit)]` | ||
| #[proc_macro_derive(VisitMut, attributes(visit))] | ||
| pub fn derive_visit_mut(input: proc_macro::TokenStream) -> proc_macro::TokenStream { | ||
| derive_visit(input, &VisitType { | ||
| visit_trait: quote!(VisitMut), | ||
| visitor_trait: quote!(VisitorMut), | ||
| modifier: Some(quote!(mut)), | ||
| }) | ||
| derive_visit( | ||
|
||
| input, | ||
| &VisitType { | ||
| visit_trait: quote!(VisitMut), | ||
| visitor_trait: quote!(VisitorMut), | ||
| modifier: Some(quote!(mut)), | ||
| }, | ||
| ) | ||
| } | ||
|
|
||
| /// Implementation of `[#derive(Visit)]` | ||
| #[proc_macro_derive(Visit, attributes(visit))] | ||
| pub fn derive_visit_immutable(input: proc_macro::TokenStream) -> proc_macro::TokenStream { | ||
| derive_visit(input, &VisitType { | ||
| visit_trait: quote!(Visit), | ||
| visitor_trait: quote!(Visitor), | ||
| modifier: None, | ||
| }) | ||
| derive_visit( | ||
| input, | ||
| &VisitType { | ||
| visit_trait: quote!(Visit), | ||
| visitor_trait: quote!(Visitor), | ||
| modifier: None, | ||
| }, | ||
| ) | ||
| } | ||
|
|
||
| struct VisitType { | ||
|
|
@@ -33,15 +38,16 @@ struct VisitType { | |
| modifier: Option<TokenStream>, | ||
| } | ||
|
|
||
| fn derive_visit( | ||
| input: proc_macro::TokenStream, | ||
| visit_type: &VisitType, | ||
| ) -> proc_macro::TokenStream { | ||
| fn derive_visit(input: proc_macro::TokenStream, visit_type: &VisitType) -> proc_macro::TokenStream { | ||
| // Parse the input tokens into a syntax tree. | ||
| let input = parse_macro_input!(input as DeriveInput); | ||
| let name = input.ident; | ||
|
|
||
| let VisitType { visit_trait, visitor_trait, modifier } = visit_type; | ||
| let VisitType { | ||
| visit_trait, | ||
| visitor_trait, | ||
| modifier, | ||
| } = visit_type; | ||
|
|
||
| let attributes = Attributes::parse(&input.attrs); | ||
| // Add a bound `T: Visit` to every type parameter T. | ||
|
|
@@ -125,17 +131,26 @@ impl Attributes { | |
| } | ||
|
|
||
| // Add a bound `T: Visit` to every type parameter T. | ||
| fn add_trait_bounds(mut generics: Generics, VisitType{visit_trait, ..}: &VisitType) -> Generics { | ||
| fn add_trait_bounds(mut generics: Generics, VisitType { visit_trait, .. }: &VisitType) -> Generics { | ||
| for param in &mut generics.params { | ||
| if let GenericParam::Type(ref mut type_param) = *param { | ||
| type_param.bounds.push(parse_quote!(sqlparser::ast::#visit_trait)); | ||
| type_param | ||
| .bounds | ||
| .push(parse_quote!(sqlparser::ast::#visit_trait)); | ||
| } | ||
| } | ||
| generics | ||
| } | ||
|
|
||
| // Generate the body of the visit implementation for the given type | ||
| fn visit_children(data: &Data, VisitType{visit_trait, modifier, ..}: &VisitType) -> TokenStream { | ||
| fn visit_children( | ||
| data: &Data, | ||
| VisitType { | ||
| visit_trait, | ||
| modifier, | ||
| .. | ||
| }: &VisitType, | ||
| ) -> TokenStream { | ||
| match data { | ||
| Data::Struct(data) => match &data.fields { | ||
| Fields::Named(fields) => { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document the steps needed to publish to crates.io: