Added support for ALTER OPERATOR syntax
#2114
Merged
+585
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Dec 4, 2025
src/parser/mod.rs
Outdated
| Keyword::MERGES => { | ||
| options.push(OperatorOption::Merges); | ||
| } | ||
| _ => unreachable!(), |
Contributor
There was a problem hiding this comment.
Can we return an error here instead?
Contributor
Author
There was a problem hiding this comment.
To future proof this, I have added:
[lints.clippy]
unreachable = "forbid"To the Cargo.toml, so it will be clearer. There are a few unreachable in the lib, I will go through them and change them into errors.
Contributor
Author
There was a problem hiding this comment.
Done, now unreachable patterns in the lib will trigger clippy. I have replaced all unreachable patterns with errors, or simplified them out when reasonable in their context.
iffyio
approved these changes
Dec 4, 2025
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @LucaCappelletti94!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, this PR adds support for the
ALTER OPERATORsyntax, and simplifies a bit the existingCREATE OPERATORstruct to reduce the code duplication between the two statement representations in the AST.