Skip to content

Conversation

@caimo
Copy link
Contributor

@caimo caimo commented Nov 8, 2025

fix null point

  • [√ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [√] Each commit in the pull request should have a meaningful subject line and body.
  • [] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • [] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.


openAPI = new OpenAPI();
schema = SwaggerUtils.resolveTypeSchemas(openAPI, TestTypeClass.class);
schema = SwaggerUtils.getSchema(openAPI, schema); // resolve reference
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be combined into a single line code.

testExcep(value.getGenericType(), field.getGenericType());
fail("IllegalArgumentException expected");
} catch (IllegalArgumentException e) {
System.out.println(value.getGenericType()+ " " + field.getGenericType() + " " +e.getMessage());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use logger to print log


openAPI = new OpenAPI();
schema = SwaggerUtils.resolveTypeSchemas(openAPI, TestTypeRecord.class);
schema = SwaggerUtils.getSchema(openAPI, schema); // resolve reference
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be combined into a single line code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants