Skip to content

Solve the problem of error when opening the job details page and erro… #4218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2025

Conversation

Aalron
Copy link
Contributor

@Aalron Aalron commented Mar 22, 2025

…r when editing the SQL task and submitting it again
#4217

What changes were proposed in this pull request

Issue Number: close #xxx

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

…r when editing the SQL task and submitting it again
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses an error when opening the job details page and an error when editing and submitting the SQL task by introducing additional update result handling and logging enhancements.

  • FlinkApplicationManageServiceImpl.java: Introduces an extra update call with a boolean check.
  • FlinkApplicationActionServiceImpl.java: Adds a creation timestamp to application logs.
  • ApplicationLog.java: Introduces a new createTime field.

Reviewed Changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

File Description
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/impl/FlinkApplicationManageServiceImpl.java Potential redundant update call and added explicit update result check
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/impl/FlinkApplicationActionServiceImpl.java Adds a createTime timestamp when constructing application logs
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/entity/ApplicationLog.java Adds new createTime field to support logging enhancements
Files not reviewed (3)
  • streampark-console/streampark-console-service/src/main/assembly/script/schema/mysql-schema.sql: Language not supported
  • streampark-console/streampark-console-service/src/main/assembly/script/schema/pgsql-schema.sql: Language not supported
  • streampark-console/streampark-console-service/src/main/resources/db/schema-h2.sql: Language not supported
Comments suppressed due to low confidence (1)

streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/impl/FlinkApplicationManageServiceImpl.java:726

  • The update operation appears to be invoked twice; first via this.update(update) and then by update.update(). Consider removing one of these calls to prevent unintended duplicate update operations.
this.update(update);

…r when editing the SQL task and submitting it again
Copy link

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit ca1a3fd into apache:dev Mar 30, 2025
42 checks passed
Gianzie pushed a commit to Gianzie/streampark that referenced this pull request Jun 4, 2025
* application log query page bug fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants