[Improve] implicitUtil improvement #4243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR makes two key improvements: it renames the implicit autoClose method to using in the Scala code and removes the catalog module along with several related classes and controllers.
- Renamed autoClose to using in streampark-common to improve clarity.
- Removed catalog-related modules including service, mapper, entity, and controller classes.
Reviewed Changes
Copilot reviewed 81 out of 81 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/FlinkCatalogBase.java | Removed catalog service implementation. |
| streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/DistributedTaskService.java | Removed distributed task service interface. |
| streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/DatabaseService.java | Removed database service interface. |
| streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/runner/EnvInitializer.java | Removed initialization for RegistryService. |
| streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/mapper/* | Removed mappers associated with catalog and task modules. |
| streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/entity/* | Removed entity classes related to catalog, database, and distributed tasks. |
| streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/controller/* | Removed controllers for table, catalog, and database operations. |
| streampark-console/streampark-console-service/pom.xml | Removed dependency on streampark-flink-connector-plugin from test scope. |
| streampark-common/src/main/scala/org/apache/streampark/common/util/Implicits.scala | Renamed implicit conversion method from autoClose to using. |
| streampark-common/src/test/scala/org/apache/streampark/common/util/ImplicitsTest.scala | Updated tests to use the new using method. |
| streampark-common/src/main/scala/org/apache/streampark/common/util/Utils.scala, FileUtils.scala | Revised usage of autoClose to using. |
streampark-common/src/main/scala/org/apache/streampark/common/util/Implicits.scala
Outdated
Show resolved
Hide resolved
|
Al-assad
approved these changes
May 28, 2025
|
LGTM |
Gianzie
pushed a commit
to Gianzie/streampark
that referenced
this pull request
Jun 4, 2025
* [Improve] implicitUtil improvement * Update Implicits.scala
Gianzie
pushed a commit
to Gianzie/streampark
that referenced
this pull request
Jun 4, 2025
* [Improve] implicitUtil improvement * Update Implicits.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Improve] implicitUtil improvement
Contribution Checklist
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts