Skip to content

Conversation

@Meldiron
Copy link
Contributor

@Meldiron Meldiron commented May 24, 2025

What does this PR do?

  • Generates new console SDK with fix to site and function manual deployment methods that need chunk upload
  • Fix to manual site deployments

Test Plan

CleanShot 2025-05-25 at 00 06 33@2x

CleanShot 2025-05-25 at 00 07 02@2x

CleanShot 2025-05-25 at 00 07 15@2x

CleanShot 2025-05-25 at 00 07 30@2x

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Summary by CodeRabbit

  • Chores
    • Updated a development dependency to use a specific development branch version. No impact on end-user functionality.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 24, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The version specification for the "appwrite/sdk-generator" development dependency in composer.json was updated from a stable release ("0.40.*") to a specific development branch ("dev-fix-functions-sites-files") with an alias ("0.40.99"). The creation of the "rules" document during site deployment was enhanced to include multiple detailed fields such as deployment IDs, resource types, owner, and region instead of a single value field. No public API changes were made.

Changes

File(s) Change Summary
composer.json Updated "appwrite/sdk-generator" version from "0.40.*" to "dev-fix-functions-sites-files" as "0.40.99"
src/Appwrite/Platform/Modules/Sites/Http/...Create.php Modified creation of "rules" document during deployment to include detailed fields like deploymentId, resource info, owner, and region instead of a single 'value' field

Possibly related PRs

Suggested reviewers

  • christyjacob4

Poem

The garden of code gets a gentle tweak,
A branch now blooms where versions speak.
SDK seeds from dev now grow,
With fixes budding in the flow.
Rabbits hop and dependencies sing,
Awaiting what new changes bring! 🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented May 24, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH
libxml2 2.12.7-r0 CVE-2025-32414 HIGH
libxml2 2.12.7-r0 CVE-2025-32415 HIGH
sqlite-libs 3.45.3-r1 CVE-2025-29087 HIGH
xz 5.6.2-r0 CVE-2025-31115 HIGH
xz-libs 5.6.2-r0 CVE-2025-31115 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 24, 2025

Open in StackBlitz

npm i https://pkg.pr.new/appwrite/appwrite/@appwrite.io/console@9886

commit: d353384

@github-actions
Copy link

github-actions bot commented May 24, 2025

✨ Benchmark results

  • Requests per second: 927
  • Requests with 200 status code: 166,963
  • P99 latency: 0.199563299

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 927 1,169
200 166,963 210,389
P99 0.199563299 0.160218808

@Meldiron Meldiron merged commit 3bb5e90 into 1.7.x May 24, 2025
40 checks passed
@stnguyen90 stnguyen90 deleted the fix-console-sdk-file-upload branch May 25, 2025 02:01
@stnguyen90 stnguyen90 moved this to Done in 1.7 Release May 25, 2025
@constantinleordeanu-lang

astept

1 similar comment
@constantinleordeanu-lang

astept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants