fix(cli): prevent session cookie from being wiped #1074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the CLI would replace the cookies in the config if the server returned any cookies, even when not authenticating. This change makes it so we check for the Appwrite session cookie and only save that cookie if it's found in the response.
ChiragAgg5k
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prior to this change, the CLI would replace the cookies in the config if the server returned any cookies, even when not authenticating.
This change makes it so we check for the Appwrite session cookie and only save that cookie if it's found in the response.
Test Plan
This was happening when I was using the CLI against a codespaces instance I had. So, I manually tweaked the code and then successfully connected to the codespace without losing the session:
Related PRs and Issues
None
Have you read the Contributing Guidelines on issues?
Yes