Skip to content

chore: update flutter_web_auth_2 to 4.x #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Conversation

ChiragAgg5k
Copy link
Member

@ChiragAgg5k ChiragAgg5k commented May 22, 2025

What does this PR do?

Migration guide followed - https://pub.dev/packages/flutter_web_auth_2#upgrading-to-4x

For now we are keeping the old behaviour and disabling usage of webView for linux and windows platforms. But in future we can introduce an option to enable it.

Test Plan

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

yes.

@ChiragAgg5k ChiragAgg5k requested a review from stnguyen90 May 22, 2025 05:18
@rong6767
Copy link

As mentioned in the issue, this upgrade will raise the minimum supported iOS version for the Appwrite SDK to iOS 17.4, which I think might be a potential issue for our clients. To work around this limitation, I forked flutter_web_auth_2 and used this3.x-without-v1 branch and made a small modification so I can still use 3.x but don't have any compile errors.

@ChiragAgg5k
Copy link
Member Author

@rong6767 thats great that you have found a workaround for your use case, but we can't use the fork with appwrite 😅
this change will lead to a major bump in the sdk so you can keep on using the older appwrite version, and deal with the warnings by using this approach by Steven - appwrite/sdk-for-flutter#238 (comment)

Copy link
Member

@DH-555 DH-555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. The useWebview: false is the correct approach as that's what's required mainly by Apple

@stnguyen90 stnguyen90 mentioned this pull request May 22, 2025
@stnguyen90 stnguyen90 merged commit 0bdb584 into master May 22, 2025
37 checks passed
@stnguyen90 stnguyen90 deleted the update-flutter-web-auth-2 branch May 22, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants