fix: encode + in parametersToQueryString #1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChiragAgg5k
changed the title
abnegate
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CharacterSet.urlHostAllowedcontains the+symbol as allowed, leading to it not being encoded and errors in requests that contain it, specifically time based requests in Queries:https://stackoverflow.com/questions/41561853/couldnt-encode-plus-character-in-url-swift
The PR as the stack overflow thread suggests encodes the
+symbol separately.Test Plan
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
yes.