fix: devKeys support in flutter by conditionally including credentials #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the devKeys support in the Flutter client by conditionally setting the HTTP client's credentials based on the presence of a development key.
- Removed the unconditional assignment of withCredentials in the cookie fallback block.
- Introduced combined headers logic to conditionally enable withCredentials depending on the presence of the dev key.
Comments suppressed due to low confidence (1)
templates/flutter/lib/src/client_browser.dart.twig:195
- If _httpClient is used concurrently for multiple requests, toggling _httpClient.withCredentials per request might introduce race conditions. Ensure that this design is safe under concurrent usage or consider isolating the HTTP client state per request.
final combinedHeaders = {..._headers!, ...headers};
stnguyen90
approved these changes
May 31, 2025
|
@stnguyen90 done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes devKeys support in flutter.
When devKeys is set, we treat the authentication method as "keys" based, and thus we should not include "credentials: include". This change was also implemented in web and react native, was left in flutter.
the following error is thrown otherwise:
Test Plan
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
yes.