Skip to content

chore: exclude assistant service in cli #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

ChiragAgg5k
Copy link
Member

What does this PR do?

exclude assistant service in cli as its not needed there.

Test Plan

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

yes.

@ChiragAgg5k ChiragAgg5k requested a review from Copilot June 2, 2025 13:26
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR excludes the assistant service from the CLI generation process by adding configurable exclusion rules into the SDK.

  • Introduces an exclusion rules property and a method in SDK.php to merge additional rules.
  • Updates example.php to demonstrate setting up an exclusion for the assistant service.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/SDK/SDK.php Adds an exclusion rules property and a setExclude method for merging custom exclusion rules.
example.php Demonstrates the usage of setExclude to exclude the assistant service in the CLI context.

@ChiragAgg5k ChiragAgg5k requested a review from loks0n June 2, 2025 14:19
@lohanidamodar lohanidamodar merged commit 9c9a7db into master Jun 4, 2025
37 checks passed
@lohanidamodar lohanidamodar deleted the chore-exclude-assistant branch June 4, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants