Add Sendable
conformance to public structs
#362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
Sendable
protocol conformance to a number of core data structures throughout the WhisperKit codebase. This update improves the safety and correctness of concurrent code by ensuring these types can be safely passed across threads, which is particularly important for Swift Concurrency. No other functional changes are introduced.Concurrency and thread safety improvements:
Sendable
conformance to key structs and enums related to audio processing, configuration, model support, and transcription, such asAudioDevice
,AudioInputConfig
,DecodingOptions
,ModelComputeOptions
,ModelSupport
,DeviceSupport
,ModelSupportConfig
,AudioChunk
,DecodingTask
,DecodingFallback
,TranscriptionResult
,TranscriptionSegment
,WordTiming
,TranscriptionProgress
,TranscriptionTimings
,SpecialTokens
, andSamplingResult
.