-
Notifications
You must be signed in to change notification settings - Fork 314
feat(chart-updater): continuous deployment of OCI Helm chart type application #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master-annotation-based
Are you sure you want to change the base?
feat(chart-updater): continuous deployment of OCI Helm chart type application #405
Conversation
…lication Update application targetRevision for an OCI helm chart when new chart version arrives into the container registry based on semver constraints. Signed-off-by: Timofey Kirillov <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master-annotation-based #405 +/- ##
===========================================================
- Coverage 65.55% 63.08% -2.47%
===========================================================
Files 21 21
Lines 2032 2132 +100
===========================================================
+ Hits 1332 1345 +13
- Misses 571 656 +85
- Partials 129 131 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jannfis Could you please review this ? Thank you so much |
|
@jannfis Thanks in advance for your review. |
|
@jannfis We really need this feature! |
|
@distorhead Could you accept the licensing and go forward with this feature? |
@mxzinke Hi! I am sorry for delayed response, accepted licensing. |
|
@jannfis Hi! What do you think about this feature? Does it have any problems with design? |
|
Hi @jannfis, Could you please take a look on this PR ? Thanks. |
|
Any chance this will go forward? |
|
I really don't understand what's wrong with this PR and why repo maintainers like @jannfis don't care about this while many people are waiting for this. |
Hi! There is a proposal to implement continuous deployment at the higher logical level than updating images: watch for a new helm chart versions and perform update (and included images will be updated as well). This proposal and possible solutions has been described in-depth in this issue: argoproj/argo-cd#8475.
In this PR I've created MVP to try one solution to the problem and get your feedback if possible.
How it works
Update application targetRevision for an OCI helm chart when new chart version arrives into the container registry based on semver constraints.