Skip to content

Conversation

@distorhead
Copy link

@distorhead distorhead commented Mar 15, 2022

Hi! There is a proposal to implement continuous deployment at the higher logical level than updating images: watch for a new helm chart versions and perform update (and included images will be updated as well). This proposal and possible solutions has been described in-depth in this issue: argoproj/argo-cd#8475.

In this PR I've created MVP to try one solution to the problem and get your feedback if possible.

How it works

Update application targetRevision for an OCI helm chart when new chart version arrives into the container registry based on semver constraints.

…lication

Update application targetRevision for an OCI helm chart when new chart version arrives into the container registry based on semver constraints.

Signed-off-by: Timofey Kirillov <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Mar 15, 2022

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

❌ Patch coverage is 14.70588% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.08%. Comparing base (e46a206) to head (1df2f88).
⚠️ Report is 377 commits behind head on master-annotation-based.

Files with missing lines Patch % Lines
pkg/argocd/update.go 0.00% 76 Missing and 1 partial ⚠️
pkg/argocd/argocd.go 60.00% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           master-annotation-based     #405      +/-   ##
===========================================================
- Coverage                    65.55%   63.08%   -2.47%     
===========================================================
  Files                           21       21              
  Lines                         2032     2132     +100     
===========================================================
+ Hits                          1332     1345      +13     
- Misses                         571      656      +85     
- Partials                       129      131       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsg-toby
Copy link

@jannfis Could you please review this ? Thank you so much

@dtduc-git
Copy link

@jannfis Thanks in advance for your review.

@minhnnhat
Copy link

@jannfis We really need this feature!

@mxzinke
Copy link

mxzinke commented Sep 30, 2022

@distorhead Could you accept the licensing and go forward with this feature?

@distorhead
Copy link
Author

@distorhead Could you accept the licensing and go forward with this feature?

@mxzinke Hi! I am sorry for delayed response, accepted licensing.

@distorhead
Copy link
Author

@jannfis Hi! What do you think about this feature? Does it have any problems with design?

@bsg-toby
Copy link

Hi @jannfis,

Could you please take a look on this PR ? Thanks.

@vietwow
Copy link

vietwow commented Dec 13, 2022

@alexmt @jannfis anyone could take a look this pr ? thanks

@asychev
Copy link

asychev commented Feb 8, 2023

Any chance this will go forward?

@vietwow
Copy link

vietwow commented Jul 14, 2023

I really don't understand what's wrong with this PR and why repo maintainers like @jannfis don't care about this while many people are waiting for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants