fix: select correct legacy version (closes #358) #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubiin
approved these changes
Aug 17, 2023
Stratus3D
reviewed
Jun 20, 2024
lib/utils.sh
Outdated
| latest_installed) | ||
| _list() { | ||
| ASDF_NODEJS_SKIP_NODEBUILD_UPDATE=1 list_installed_versions nodejs | ||
| ASDF_NODEJS_SKIP_NODEBUILD_UPDATE=1 list_installed_versions nodejs | sort -V |
Member
There was a problem hiding this comment.
I don't think sort -V is available on older versions of MacOS. In asdf we had to do this: https://github.com/asdf-vm/asdf/blob/ccdd47df9b73d0a22235eb06ad4c48eb57360832/lib/commands/command-update.bash#L45-L49
Contributor
Author
There was a problem hiding this comment.
I don't think
sort -Vis available on older versions of MacOS. In asdf we had to do this: https://github.com/asdf-vm/asdf/blob/ccdd47df9b73d0a22235eb06ad4c48eb57360832/lib/commands/command-update.bash#L45-L49
This could be used instead. I copied sort_versions into this PR.
As I already noted in #358, asdf itself wants coreutils to be installed on macOS, but I guess that does not include the requirement that GNU sort should be first in $PATH.
Stratus3D
approved these changes
Jun 20, 2024
Member
|
Thanks @luzat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.