This repository was archived by the owner on Dec 20, 2018. It is now read-only.
Block enabled 2fa in the UI without cookie consent #2035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried out the code via scaffolding the fix into a 2.1 app and it seems fine:
This broke a bunch of functional tests so we actually do have coverage, the tests now have some minimal coverage for enabling 2fa behavior with and without cookie consent now. |
ajcvickers
approved these changes
Oct 29, 2018
|
What happens if the dev removed all the consent code? |
|
They would need to remove this as well I assume? Or does CanTrack cover that case? |
|
I don't know, that's what I'm asking. I would have hoped the check defaulted to true if there was no consent feature, but ... |
|
Are you telling me CanTrack returns false by default? @Tratcher any insight into the behavior? |
Tratcher
reviewed
Oct 30, 2018
src/UI/Areas/Identity/Pages/V3/Account/Manage/TwoFactorAuthentication.cshtml
Outdated
Show resolved
Hide resolved
|
Updated to assume if no consent feature is there, that means we are good to go (and to allow 2fa) |
Eilon
approved these changes
Oct 30, 2018
src/UI/Areas/Identity/Pages/V3/Account/Manage/TwoFactorAuthentication.cshtml
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2034