This repository was archived by the owner on Feb 12, 2022. It is now read-only.
Parameter Namespacing: Refactoring using the ParameterPath object. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return string representing the full, resolved path of the parameter. | ||
| * @note If node_namespaces and parameter_path_keys are empty, an empty string would be returned. | ||
| */ | ||
| std::string get_resolved_path(char node_namespace_separator, |
There was a problem hiding this comment.
Is this intended to be able to convert ROS2->ROS1 paths as well? If not we should specify that in the constructor and deprecate it. This get_resolved_path almost is able to do both, and could be abused that way.
Here is an example of a confusing result of this API e.g.
std::string ros2_key_success = "key_ns.key"
auto ParameterPath key_1(ros2_key_success);
auto key_1_resolved = key_1.get_resolved_path('/','/',true); // = "key_ns/key"
std::string ros2_key_fail = "/node_name." + ros2_key_success
auto ParameterPath key_2(ros2_key_fail);
auto key_2_resolved = key_2.get_resolved_path('/','/',true); // = "/node_name.key_ns.key"It would be awesome if we could only support ROS1->ROS2 and not have a public API to "get_resolved_path". We can do this by putting get_resolved_path within the rosparamreader itself, that way each param reader (1 or 2) can choose how to format the parameter path, without exposing the confusing possibility above.
Does that make sense?
| } | ||
| } | ||
| private: | ||
| const std::vector<std::string> parameter_path_keys_; |
ross-desmond
previously requested changes
Jan 17, 2019
mm318
reviewed
Jan 21, 2019
| */ | ||
| const std::vector<std::string> parameter_path_keys_; | ||
| const std::vector<std::string> node_namespaces_; | ||
| mutable std::string name_; |
There was a problem hiding this comment.
This doesn't need to be mutable anymore.
…ientConfigurationProvider accordingly.
…ents remain unchanged if the query was unsuccessful.
…der API accepting ParameterPath.
|
Addressed feedback. |
mm318
approved these changes
Jan 22, 2019
mm318
added a commit
that referenced
this pull request
Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related change: aws-robotics/utils-ros1#3
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.