This repository was archived by the owner on Feb 12, 2022. It is now read-only.
Fix tests not running & optimize build time #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm318
reviewed
Jan 25, 2019
| cmake_minimum_required(VERSION 3.0.2) | ||
| project(AWSSDK) | ||
| set(AWSSDK_VERSION 1.4.90) | ||
| set(AWSSDK_VERSION 1.6.53) |
There was a problem hiding this comment.
How did you decide on this particular version of the AWS C++ SDK?
There was a problem hiding this comment.
It's the latest 1.6.x version because 1.7.x breaks the build. They took on additional dependencies which they install in a nonstandard fashion which would require additional work to get it working via the ExternalProject way (see aws/aws-sdk-cpp#1037).
mm318
approved these changes
Jan 26, 2019
There was a problem hiding this comment.
Just want to note that other packages need to follow suit with the changes to this packages (moving to catkin/ament gtest/gmock and needing to get a Json::JsonView from Json::JsonValue now). Also, this change is incompatible with ROS2. Even once it supports ROS2, rosdep >= 0.15.0 is required.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.