Skip to content
This repository was archived by the owner on Feb 12, 2022. It is now read-only.

Conversation

@AAlon
Copy link
Contributor

@AAlon AAlon commented Aug 10, 2019

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #42 into master will decrease coverage by 7.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   89.03%   81.33%   -7.71%     
==========================================
  Files          16       11       -5     
  Lines         830      375     -455     
==========================================
- Hits          739      305     -434     
+ Misses         91       70      -21
Flag Coverage Δ
#ROS_1 81.33% <ø> (-7.71%) ⬇️
#ROS_2 81.23% <ø> (-10.1%) ⬇️
#dashing 81.23% <ø> (-10.1%) ⬇️
#kinetic 81.36% <ø> (-7.77%) ⬇️
#melodic 81.23% <ø> (-10.1%) ⬇️
Impacted Files Coverage Δ
...k_utils/auth/service_credentials_provider_test.cpp
...t/sdk_utils/client_configuration_provider_test.cpp
...mon/test/sdk_utils/logging/aws_log_system_test.cpp
..._common/test/sdk_utils/throttling_manager_test.cpp
...clude/aws_common/sdk_utils/parameter_reader_mock.h

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c0d9e...36547db. Read the comment docs.

@AAlon AAlon merged commit 855b91e into master Aug 12, 2019
@ryanewel ryanewel deleted the cov-fix branch October 31, 2019 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants