manually add workflow approval #146
Merged
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zicanl-amazon
force-pushed
the
workflow-approval
branch
from
5062413 to
cfb7431
Compare
zicanl-amazon
force-pushed
the
workflow-approval
branch
from
cfb7431 to
2e01448
Compare
zicanl-amazon
assigned
zicanl-amazon,
Satish615 and
oyangz and unassigned
zicanl-amazon,
Satish615 and
oyangz
oyangz
approved these changes
Mar 24, 2025
Contributor
oyangz
left a comment
oyangz
left a comment
There was a problem hiding this comment.
Looks like the Python tests are failing. Approving since this only changes the approval workflow.
Contributor
|
remove internal ticket links from the PR. Unit tests are failing on older environments, which is unrelated to this change. Approving to unblock for now |
Satish615
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #,
*Description of changes:
Ensure that your GitHub workflows cannot be automatically triggered when a non-contributor submits a pull request or using similar event. Especially if you have workflows that run integration tests, please ensure a manual approval step is added before triggering the workflow.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.