fix: list_events with branch & eventMetadata filter #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glsukki
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
bergjaak
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Existing
MemorySessionManager.list_events()implementation of listing events with bothbranchandeventMetadatafilter had a bug. If both the filters were provided, theeventMetadatafilter was over-writing thebranchfilter.This led towards the listing of events with
eventMetadatafiltering across all the events present in the session as compared to the expected behavior of listing only the events that adhere to theeventMetadatafilter conditions present in thebranchspecified.Description of changes:
This PR fixes the above issue by creating a
filterMapthat takes in both branch and eventMetadata filter when provided duringlist_events()invocation.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.