-
Notifications
You must be signed in to change notification settings - Fork 196
62350 deep dive basho internals #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
djschlegel2
wants to merge
25
commits into
basho:master
from
cloudant:62350-deep-dive-basho_internals
Closed
62350 deep dive basho internals #206
djschlegel2
wants to merge
25
commits into
basho:master
from
cloudant:62350-deep-dive-basho_internals
+570
−5,479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf37 use notify existing metrics
basho_bench_sup now monitors basho_bench_config, which is now long-lived. It also monitors basho_bench_run_sups, which are dynamically spawned and handle all the logic for a particular benchmark run.
This commit adds basho_bench_duration.erl, which is a gen_server that runs for a specified amount of time before terminating. Once it terminates, it will terminate its supervisor resulting in the end of the benchmark.
The new supervision structure requires a new supervisor for workers. This commit just moves the old logic from basho_bench_sup to a new supervisor.
Add functionality to run basho_bench as an included app
Whitespace changes & Merge PR #5 to cloudant branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick summary of (Cloudant) basho internal architecture in ORG format like README.