Skip to content

Conversation

hacst
Copy link
Contributor

@hacst hacst commented Oct 20, 2018

I'm currently looking at cpp-bredis and noticed various typos, missing articles and other minor issues w.r.t to the English grammar in the readme that made it a bit hard to read.

I tried to correct as many of them as I could find without changing the meaning or touching too much. I didn't try to do many changes to punctuation. English isn't my first language so I'm never 100% sure when to place them though I'm pretty sure one could remove a lot of the ","s.

Fix various typos, missing articles and other minor issues w.r.t to
English grammar in the readme.
@codecov
Copy link

codecov bot commented Oct 20, 2018

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   93.28%   93.28%           
=======================================
  Files          11       11           
  Lines         402      402           
=======================================
  Hits          375      375           
  Misses         27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76c39d9...b22b931. Read the comment docs.

@basiliscos
Copy link
Owner

Wow! There is a lot of work is done! Thanks a lot!

@basiliscos basiliscos merged commit 9e1906b into basiliscos:master Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants