Make Windows MSVC builds actually deterministic #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the `/Brepro` switch to freeze the `__DATE__`, `__TIME__`, `__TIMESTAMP__` macros, and make FileDateStamp in the PE header a hash of the resulting binary. This undocumented switch works on both clang-cl and MSVC.
mochaaP
requested review from
armandomontanez,
c-mita,
comius,
pzembrod and
trybka
as code owners
meteorcloudy
approved these changes
May 5, 2025
|
@mochaaP Thanks! Is there a minimal version requirement for this flag? |
|
I think this switch came out when they started testing reproducible builds on Windows 10, so it's likely around VS2013-2015. I found an early mention of the flag here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the
/Breproswitch to freeze the__DATE__,__TIME__,__TIMESTAMP__macros, and make FileDateStamp in the PE header a hash of the resulting binary.This undocumented switch works on both clang-cl and MSVC.
Closes bazelbuild/bazel#5750