Skip to content

Conversation

beobal
Copy link
Owner

@beobal beobal commented Sep 20, 2021

No description provided.

beobal and others added 2 commits September 17, 2021 17:58
Co-authored-by: Benedict Elliott Smith <[email protected]>
Co-authored-by: Aleksey Yeschenko  <[email protected]>
Co-authored-by: Sam Tunnicliffe <[email protected]>
Copy link

@azotcsit azotcsit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

String sclock = System.getProperty("cassandra.clock");
if (sclock == null)
sclock = System.getProperty("cassandra.monotonic_clock.precise");
String sclock = System.getProperty("cassandra.monotonic_clock.precise");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only place that caused confusion (I'm not familiar with this part of the code), but taking into account the TODO above and my expectation that this class will be replace by Clock in further PRs, I'm good.

@azotcsit azotcsit mentioned this pull request Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants