Skip to content

Conversation

demvlad
Copy link
Contributor

@demvlad demvlad commented Sep 17, 2025

Resolved vertical sliders issue on Mozila firefox browser.
The vertical sliders implementation is changed in main.css file.
It is checked on browsers:

  • Microsoft Edge
  • Mozila firefox
  • Google Chrome

Summary by CodeRabbit

  • Style
    • Converted the analyser Y-zoom control from a vertical slider to a horizontal control for improved usability.
    • Repositioned and realigned the control within the interface for clearer visibility and easier access.
    • Adjusted orientation and anchoring behavior to provide more consistent interaction across layouts and screen sizes.

Copy link

coderabbitai bot commented Sep 17, 2025

Walkthrough

CSS for the analyser Y zoom input (#analyserZoomY) was adjusted to render horizontally by changing size, position, and transform properties; vendor-specific vertical appearance was removed.

Changes

Cohort / File(s) Summary of changes
Analyser Y Zoom Control CSS
src/css/main.css
Reoriented #analyserZoomY from vertical to horizontal: width changed from 10px100px, height from 100px10px; removed -webkit-appearance: slider-vertical; top moved from 30px130px (left remains 1085px); added float: right; transform: rotate(-90deg); transform-origin: left top.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f179f8 and 299aaf1.

📒 Files selected for processing (1)
  • src/css/main.css (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/css/main.css

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Pre-merge checks

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description Check ❓ Inconclusive The PR description states the change (vertical slider fix in main.css) and lists browsers tested, but it is minimal and does not follow the repository guidance because it omits key verification and contextual details required by the template: a clear problem/reproduction statement, explicit verification steps and expected behavior (including browser versions), CI/build status or test results, and references to related issues or commits; it also contains a spelling typo ("Mozila" → "Mozilla"). Because these items are missing the description is too brief to be considered fully complete. Please expand the PR description to include a short problem statement and reproduction steps, clear verification steps and expected results (with browser versions and screenshots if available), CI/build status or test logs, and any related issue numbers or commit/squash notes; also correct the "Mozila" typo to "Mozilla" and confirm the target branch. Once those details are added the description can be re-evaluated for completeness.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title directly describes the PR's primary change—fixing vertical slider behavior in Firefox—so it accurately summarizes the main purpose of the changeset; however it includes a misspelling ("Mozila") and inconsistent capitalization ("firefox") which reduce clarity and professionalism.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a916e1e and 1f179f8.

📒 Files selected for processing (1)
  • src/css/main.css (1 hunks)

@demvlad demvlad closed this Sep 17, 2025
@demvlad demvlad reopened this Sep 17, 2025
@demvlad demvlad marked this pull request as draft September 17, 2025 11:27
Copy link

Copy link

Preview URL: https://299aaf19.betaflight-blackbox.pages.dev

@demvlad demvlad marked this pull request as ready for review September 17, 2025 11:31
@haslinghuis haslinghuis added this to the 4.0.0 milestone Sep 17, 2025
@nerdCopter
Copy link
Member

image

Firefox 128.14.0esr (64-bit)
Debian GNU/Linux 13

@haslinghuis haslinghuis merged commit 7f154cc into betaflight:master Sep 17, 2025
5 checks passed
@demvlad demvlad deleted the vert_slider_firefox_issue branch September 17, 2025 18:49
@haslinghuis haslinghuis linked an issue Sep 17, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Analyzer window vertical zoom breakage in Firefox

3 participants