Skip to content

Add missing GPS Rescue Throttle PID debug fields #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

Add missing GPS Rescue Throttle PID debug fields #859

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1092c04
Add GPS Rescue debug fields
haslinghuis Sep 24, 2025
985cb3b
Further updates
haslinghuis Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions src/flightlog_fields_presenter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,7 +1252,7 @@ FlightLogFieldPresenter.adjustDebugDefsList = function (
"debug[7]": "Not Used",
};
DEBUG_FRIENDLY_FIELD_NAMES.GPS_RESCUE_THROTTLE_PID = {
"debug[all]": "GPS Rescue Altitude",
"debug[all]": "GPS Rescue Throttle PID",
"debug[0]": "Throttle P",
"debug[1]": "Throttle D",
"debug[2]": "Altitude",
Expand Down Expand Up @@ -1287,17 +1287,6 @@ FlightLogFieldPresenter.adjustDebugDefsList = function (
"debug[6]": "Not Used",
"debug[7]": "Not Used",
};
DEBUG_FRIENDLY_FIELD_NAMES.GPS_RESCUE_THROTTLE_PID = {
"debug[all]": "GPS Rescue throttle PIDs",
"debug[0]": "Throttle P",
"debug[1]": "Throttle D",
"debug[2]": "Altitude",
"debug[3]": "Target altitude",
"debug[4]": "Not Used",
"debug[5]": "Not Used",
"debug[6]": "Not Used",
"debug[7]": "Not Used",
};
}

if (semver.gte(firmwareVersion, '4.5.0')) {
Expand All @@ -1312,6 +1301,17 @@ FlightLogFieldPresenter.adjustDebugDefsList = function (
"debug[6]": "Pitch forward angle",
"debug[7]": "dcmKp gain",
};
DEBUG_FRIENDLY_FIELD_NAMES.GPS_RESCUE_THROTTLE_PID = {
"debug[all]": "GPS Rescue throttle PID",
"debug[0]": "Throttle P",
"debug[1]": "Throttle D",
"debug[2]": "Altitude",
"debug[3]": "Target altitude",
"debug[4]": "Throttle I",
"debug[5]": "Tilt adjustment",
"debug[6]": "Throttle D before lp smoothing",
"debug[7]": "Throttle adjustment",
};
}

if (semver.gte(firmwareVersion, '2025.12.0')) {
Expand Down Expand Up @@ -2152,7 +2152,9 @@ FlightLogFieldPresenter.decodeDebugFieldToFriendly = function (
case "GPS_RESCUE_THROTTLE_PID":
switch (fieldName) {
case "debug[0]": // Throttle P added uS
case "debug[1]": // Throttle D added * uS
case "debug[1]": // Throttle D added uS
case "debug[4]": // Throttle I added uS
case "debug[6]": // Throttle D before lp smoothing uS
return `${value.toFixed(0)} uS`;
case "debug[2]": // current altitude in m
case "debug[3]": // TARGET altitude in m
Expand Down Expand Up @@ -2901,6 +2903,8 @@ FlightLogFieldPresenter.ConvertDebugFieldValue = function (
switch (fieldName) {
case "debug[0]": // Throttle P added uS
case "debug[1]": // Throttle D added * uS
case "debug[4]": // Throttle I added uS
case "debug[6]": // Throttle D before lp smoothing uS
return value; // ' uS';
case "debug[2]": // current altitude in m
case "debug[3]": // TARGET altitude in m
Expand Down