Skip to content

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Sep 29, 2025

Summary by CodeRabbit

  • Chores
    • Updated project Node.js requirement to 24.x (was 20.x). Users running the app locally should upgrade their Node runtime for compatibility.
    • Refreshed CI/deployment automation to use newer action versions; infrastructure updated with no changes to workflow behavior or sequencing.

Copy link

coderabbitai bot commented Sep 29, 2025

Walkthrough

Updated three GitHub Actions steps to v5 in the deploy-preview workflow and aligned the project's Node.js runtime to v24 by updating .nvmrc and package.json engines. No workflow logic, control flow, or public API signatures were changed.

Changes

Cohort / File(s) Summary
CI workflow action versions
.github/workflows/deploy-preview.yml
Updated action versions: actions/checkout@v4 → @v5, actions/setup-node@v4 → @v5, actions/download-artifact@v4 → @v5. Inputs and step order unchanged.
Runtime Node version alignment
.nvmrc, package.json
.nvmrc updated from v20.10.0v24.9.0. package.json engines field updated from 20.x24.x. No other changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request does not include any description content and does not follow the repository’s required PR template, which mandates important considerations and structured sections. Please provide a detailed pull request description using the repository template, including sections for change summary, considerations, and any related issue references.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly summarizes the primary changes—bumping the Node.js runtime and upgrading GitHub Actions steps—without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a879601 and 9a94ed8.

📒 Files selected for processing (2)
  • .nvmrc (1 hunks)
  • package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • package.json
  • .nvmrc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/deploy-preview.yml (1)

35-35: Inconsistent artifact action versions: upload@v4 vs download@v5.

The workflow uses actions/upload-artifact@v4 (line 35) but actions/download-artifact@v5 (line 53). GitHub's artifact actions should typically use matching major versions to ensure compatibility. Consider updating upload-artifact to v5 as well.

Apply this diff to align the versions:

       - name: Upload build artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         with:
           name: dist-files
           path: dist

Also applies to: 53-53

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7224a5 and a879601.

📒 Files selected for processing (3)
  • .github/workflows/deploy-preview.yml (3 hunks)
  • .nvmrc (1 hunks)
  • package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: nerdCopter
PR: betaflight/blackbox-log-viewer#822
File: .github/workflows/deploy-preview.yml:17-19
Timestamp: 2025-05-14T16:08:27.254Z
Learning: For betaflight/blackbox-log-viewer repository, the team is aware of the security implications of using `pull_request_target` without specifying `persist-credentials: false` in the checkout action, and has chosen to proceed with the current approach. This concern should not be flagged in future reviews.
🔇 Additional comments (2)
package.json (1)

46-48: Verify Node.js 22.x compatibility for core dependencies.

Please confirm that the following packages support Node.js 22.x by checking their official release notes or documentation:

  • eslint @^8.24.0
  • eslint-config-prettier @^8.5.0
  • jquery @^3.7.1
  • jquery-ui @^1.13.2
  • vite @^5.4.20
  • vite-plugin-pwa @^0.19.7
.nvmrc (1)

1-1: No action needed: Node.js 22.20.0 is valid and up to date. Confirmed that v22.20.0 is the latest stable 22.x Active LTS release (September 24, 2025).

Copy link

Copy link

Preview URL: https://pr863.betaflight-blackbox.pages.dev

@haslinghuis haslinghuis merged commit 5e28a44 into betaflight:master Sep 30, 2025
5 checks passed
@haslinghuis haslinghuis deleted the update-actions branch September 30, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants