-
-
Notifications
You must be signed in to change notification settings - Fork 156
Update node and github actions #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated three GitHub Actions steps to v5 in the deploy-preview workflow and aligned the project's Node.js runtime to v24 by updating Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/deploy-preview.yml (1)
35-35
: Inconsistent artifact action versions: upload@v4 vs download@v5.The workflow uses
actions/upload-artifact@v4
(line 35) butactions/download-artifact@v5
(line 53). GitHub's artifact actions should typically use matching major versions to ensure compatibility. Consider updating upload-artifact to v5 as well.Apply this diff to align the versions:
- name: Upload build artifact - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v5 with: name: dist-files path: distAlso applies to: 53-53
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/deploy-preview.yml
(3 hunks).nvmrc
(1 hunks)package.json
(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: nerdCopter
PR: betaflight/blackbox-log-viewer#822
File: .github/workflows/deploy-preview.yml:17-19
Timestamp: 2025-05-14T16:08:27.254Z
Learning: For betaflight/blackbox-log-viewer repository, the team is aware of the security implications of using `pull_request_target` without specifying `persist-credentials: false` in the checkout action, and has chosen to proceed with the current approach. This concern should not be flagged in future reviews.
🔇 Additional comments (2)
package.json (1)
46-48
: Verify Node.js 22.x compatibility for core dependencies.Please confirm that the following packages support Node.js 22.x by checking their official release notes or documentation:
- eslint @^8.24.0
- eslint-config-prettier @^8.5.0
- jquery @^3.7.1
- jquery-ui @^1.13.2
- vite @^5.4.20
- vite-plugin-pwa @^0.19.7
.nvmrc (1)
1-1
: No action needed: Node.js 22.20.0 is valid and up to date. Confirmed that v22.20.0 is the latest stable 22.x Active LTS release (September 24, 2025).
dd90896
to
9a94ed8
Compare
|
Preview URL: https://pr863.betaflight-blackbox.pages.dev |
Summary by CodeRabbit