-
-
Notifications
You must be signed in to change notification settings - Fork 156
Added TELEMETRY_MAVLINK debug fields settings #864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds MAVLINK_TELEMETRY as a debug mode (gated at firmwareVersion >= 2025.12.0), adds friendly field-name mappings for MAVLink telemetry, and provides default graph ranges for its debug indices. No exported signatures changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant UI as UI
participant Presenter as FlightLogFieldsPresenter
participant GC as GraphConfig
participant Renderer as Graph Renderer
UI->>Presenter: Select debug mode = MAVLINK_TELEMETRY
Presenter-->>UI: Friendly names (debug[all], debug[0..3])
loop For each selected field debug[i]
UI->>GC: getDefaultCurveForField("debug[i]", MAVLINK_TELEMETRY)
alt i == 0
GC-->>UI: MinMax {min:0, max:1}
else i == 1 or i == 2
GC-->>UI: MinMax {min:0, max:100}
else i == 3
GC-->>UI: MinMax {min:0, max:50}
else other
GC-->>UI: getCurveForMinMaxFields(...)
end
end
UI->>Renderer: Render curves with ranges
Renderer-->>UI: Display telemetry debug graphs
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The code checking before commits is the nice feature! |
Perhaps the sonarqubecloud have learned the new code rules! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow 10 debug modes added in one release
14e8ef0
|
Preview URL: https://pr864.betaflight-blackbox.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing indentation
👾
Added TELEMETRY_MAVLINK debug fields settings for "Added flow control for MAVLink telemetry" PR
Summary by CodeRabbit