Skip to content

Conversation

@rtalvarez
Copy link
Member

@rtalvarez rtalvarez commented Oct 2, 2023

What?

  • Adds the ability to override api_url and login_url as part of the oAuth flow.
  • Removes the stale codeless/jugglecode dependency as it seems it no longer exists and composer fails trying to fetch it (https://github.com/codeless/JuggleCode is a 404)
  • phpstan was complaining about a few things in the file I edited, so I tweaked some type docs to fix it, which in turn made some of the baseline neon definitions not applicable anymore. Seems reasonable to me, but LMK if a preferred method exists

Screenshots (if appropriate)

No screenshots to attach, but I have tested these changes in my consumer app via composer require "bigcommerce/api @dev" and verified the right URLs are being used:

If no custom URLs are provided, https://api.bigcommerce.com and https://login.bigcommerce.com are used.
If custom URLs are provided, those are being used

@rtalvarez rtalvarez marked this pull request as ready for review October 3, 2023 14:33
Copy link
Contributor

@bookernath bookernath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

🍹 perhaps auth_url instead of login_url?

Copy link

@software-artificer software-artificer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bookernath I wouldn't rename anything, because the proposed names are consistent with class members and comments used around the code.

@rtalvarez
Copy link
Member Author

rtalvarez commented Oct 4, 2023

LGTM.

@bookernath I wouldn't rename anything, because the proposed names are consistent with class members and comments used around the code.

Thanks for the pointers, makes sense, I'll leave as is then

Would you mind merging this for me if you have access? It looks like I don't have write access around this side of town. Also not sure if the process for cutting a new release is documented anywhere, I'd be interested in publishing a bump with these changes 👀

@christensenep christensenep merged commit 68ccc74 into bigcommerce:master Oct 5, 2023
@rtalvarez rtalvarez deleted the add-url-configs branch October 5, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants