Adds new secure env keys for the canonical repository #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Damn it. I'll have another look at the cause of this later. |
added 2 commits
October 1, 2013 17:58
* Added group key to "smoke" test * Removed secure keys that do not apply to canonical * Added script line to Travis CI config to switch based on the repo being built
Contributor
|
If I understand this correctly, a merge should sync up |
maetl
added a commit
that referenced
this pull request
Oct 1, 2013
Adds new secure env keys for the canonical repository
Author
|
🙇 Thanks, I should have left a comment on the state of this PR after the last two commits. |
Contributor
|
Build is passing, so all is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💁 I'd neglected to note that Travis CI's secure environment variables are tied to specific repositories. This change adds in secure variables for the
bigcommerce/bigcommerce-api-phprepository.As the smoke tests are the only tests that require these variables, they may need to be isolated to only run on the canonical repository. This will prevent false failures for pull requests coming in from other forks.