Skip to content

Conversation

andreasbuhr
Copy link

Another option to implement
#260

@tzlaine
Copy link
Collaborator

tzlaine commented Oct 13, 2025

This is the kind of thing I'd like to avoid -- it's pretty complicated for what it does. For instance, the FromFormat == ToFormat and FromFormat != ToFormat cases have different invariants. The read position is before the current cp for the former, and after it for the latter. I think it would be clearer to just pick the right iterator in the first place. IOW, the equivalent to the FromFormat != ToFormat check should happen at the point where we choose whether to use utf_iterator or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants