Fix single-element tuple generation in WIT bindings #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Single-element tuples in Rust require a trailing comma to distinguish them from parentheses used for grouping. The generator was producing (String) instead of (String,) for single-element tuples, causing compilation errors. This fix adds logic to append a comma when generating single-element tuples in the TypeDefKind::Tuple case.
pchickey
reviewed
Jun 3, 2025
| } | ||
| if t.types.len() == 1 { | ||
| source.push(','); | ||
| } |
Contributor
There was a problem hiding this comment.
Instead, can we rewrite the loop body above this statement to be:
self.print_type(ty, trie, source)?;
source.push_str(", ");
Contributor
Author
There was a problem hiding this comment.
Absolutely! Should we remove the training comma for multi-element tuples or leave it for a formatter to take care of?
Contributor
There was a problem hiding this comment.
The formatter will take care of it, and its valid syntax even if not, so I think its fine to leave it in
Contributor
Author
There was a problem hiding this comment.
Perfect sounds good
pchickey
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single-element tuples in Rust require a trailing comma to distinguish them from parentheses used for grouping. The generator was producing (String) instead of (String,) for single-element tuples, causing compilation errors.
This fix adds logic to append a comma when generating single-element tuples in the TypeDefKind::Tuple case.
I have added a conditional after the tuple loop and a test for the expected behavior, let me know if there is anything else I should do!