Enables support for user-specified *http.Clients. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an *http.Client to the main Client struct (and automatically defaults to http.DefaultClient if nil is provided). This permits the user to set important client attributes such as request timeouts (since the default is never to time out). Requires API change from NewClient() to NewClient(nil) or NewClient(*http.Client). Tests are updated and pass.
Author
|
Would be happy to modify this to keep NewClient() intact and to create an alternative initializer to prevent this change from breaking old apps. Let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an *http.Client to the main Client struct (and automatically defaults to http.DefaultClient if nil is provided). This permits the user to set important client attributes such as request timeouts (since the default is never to time out).
Requires API change from NewClient() to NewClient(nil) or NewClient(*http.Client).
Tests are updated and pass.