Skip to content
This repository was archived by the owner on Nov 28, 2018. It is now read-only.

scrollToBottom doesn't work width jQuery 1.6+ because of the new the .prop() method #14

Merged
merged 1 commit into from
Dec 12, 2011

Conversation

moretti
Copy link
Contributor

@moretti moretti commented Dec 12, 2011

Following issue #13

@chrisdone
Copy link
Collaborator

Cheers!

chrisdone added a commit that referenced this pull request Dec 12, 2011
scrollToBottom doesn't work width jQuery 1.6+ because of the new the .prop() method
@chrisdone chrisdone merged commit f244e8b into chrisdone-archive:master Dec 12, 2011
@semperos
Copy link

Using jQuery 1.7.2. This doesn't appear to be working out-of-the-box for me. Are there any gotcha's? When I click inside the jquery-conosle textarea, it actually scrolls to the top instead of the bottom of the textarea.

Here is how I'm configuring the textarea:

$("#console").console({
  welcomeMessage: "Foo",
  promptLabel: "Foo> ",
  commandValidate: onValidate,
  commandHandle: onHandle,
  autofocus: true,
  animateScroll: true,
  promptHistory: true
});

The console otherwise works, but it won't continue scrolling down, so it's quite difficult to use. In case it matters, here are the styles I apply to the #console div:

.console-visible {
  height: 400px;
  background: #eee;
  margin: 5px;
  padding: 5px;
  border: 1px solid #AAA;
  font-family: monospace;
  position: fixed;
  overflow: auto;
}

@chrisdone
Copy link
Collaborator

Heh, jQuery keep breaking this feature, huh?

@semperos
Copy link

I'm sure, per usual, it's my own error. Just curious if there is anything I could have done to break the scrolling, if all other jquery-console features appear to be working.

@chrisdone
Copy link
Collaborator

I'd say if the demo.html exhibits the behavior then it's a jquery bug, not your fault.

@semperos
Copy link

I just cloned this project, edited demo.html to use jQuery 1.7.2 instead of its default 1.4.2, and it works fine. Are you saying you can replicate my issue using demo.html?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants