-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(help): Allow styling for inline context #6057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
91cd85a
to
c4a268a
Compare
Done, I removed all the granularity and left only context and context_data (also eddited the documentation) Sorry for the confusion. I saw it as an improvement, but I understand that we need to discuss it beforehand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing else jumps out.
cb04ae0
to
aa8964e
Compare
Thanks for doing those updates! |
Hi @epage, I am guessing you are very busy, but I am too, and I would like to finish this PR asap please. When will you be more available to react to my replies and comments? |
Understand that you posted during a US holiday. I've been with my family. It is not healthy for maintainers to be pressured to respond at all time like that. Yes, I didn't get to it today but it takes time to catch up. |
I am sorry. Didn't mean to come out rude and to pressure you. Hope you enjoyed your time with your family, and stay healthy, I know that it is very hard to be a maintainer of an open-source project, especially a popular one such as clap. It has been 5 days since I heard from you and got scared you forgot this PR or put it in the backlog as I know you are very involved with other projects as well (typos, toml and cargo...). (By the way, I just realized that you are in Texas, hope you, your family and friends are OK with the flooding) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know about the "pending" comments.... Had no idea you could not see them even.
I apologize for my miscommunication. I learned for next time.
Styles [aliases],[default],[env],[possible values] and their values
Thanks! |
You are welcome! It's ok, I will do it in another PR |
Styles for [aliases], [default], [env], and [possible values] as well as their values
fix #5093
Continuation of PR #5482 but clean.
I created an issue (#6056) about
literal
possible values in long help for when 5.0 is rolling out as @pksunkara asked.I added more granularity in the styling of each "context" but still a general one to style all of them at once too.