Skip to content

feat(help): Allow styling for inline context #6057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025

Conversation

GilShoshan94
Copy link
Contributor

Styles for [aliases], [default], [env], and [possible values] as well as their values

fix #5093

Continuation of PR #5482 but clean.

I created an issue (#6056) about literal possible values in long help for when 5.0 is rolling out as @pksunkara asked.

I added more granularity in the styling of each "context" but still a general one to style all of them at once too.

@GilShoshan94 GilShoshan94 force-pushed the master branch 5 times, most recently from 91cd85a to c4a268a Compare July 1, 2025 22:01
@GilShoshan94
Copy link
Contributor Author

@epage

Done, I removed all the granularity and left only context and context_data (also eddited the documentation)

Sorry for the confusion. I saw it as an improvement, but I understand that we need to discuss it beforehand.
I will open a new issue and new PR once this get merged.

Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing else jumps out.

@epage
Copy link
Member

epage commented Jul 3, 2025

Thanks for doing those updates!

@GilShoshan94
Copy link
Contributor Author

GilShoshan94 commented Jul 8, 2025

Hi @epage,

I am guessing you are very busy, but I am too, and I would like to finish this PR asap please.

When will you be more available to react to my replies and comments?
I just updated the PR and now it passes the CI.

@epage
Copy link
Member

epage commented Jul 8, 2025

Understand that you posted during a US holiday. I've been with my family. It is not healthy for maintainers to be pressured to respond at all time like that. Yes, I didn't get to it today but it takes time to catch up.

@GilShoshan94
Copy link
Contributor Author

GilShoshan94 commented Jul 8, 2025

I am sorry. Didn't mean to come out rude and to pressure you. Hope you enjoyed your time with your family, and stay healthy, I know that it is very hard to be a maintainer of an open-source project, especially a popular one such as clap.

It has been 5 days since I heard from you and got scared you forgot this PR or put it in the backlog as I know you are very involved with other projects as well (typos, toml and cargo...).
I just wanted to know that it was not the case.
The more I am pushing PRs, the more I will understand how to proceed with maintainers and what to expect. I just want to contribute and help when and where I can.

(By the way, I just realized that you are in Texas, hope you, your family and friends are OK with the flooding)

Copy link
Contributor Author

@GilShoshan94 GilShoshan94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about the "pending" comments.... Had no idea you could not see them even.
I apologize for my miscommunication. I learned for next time.

@epage epage merged commit 0f60239 into clap-rs:master Jul 9, 2025
25 checks passed
@epage
Copy link
Member

epage commented Jul 9, 2025

Thanks!

@GilShoshan94
Copy link
Contributor Author

GilShoshan94 commented Jul 9, 2025

You are welcome!
But I didn't finish, I was adding the fix #6067...

It's ok, I will do it in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow customizing styling of [default], [possible values], [env] in arg description
3 participants