Implemented a nodelet version of the driver. #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that the library is compiled with position independent code.
|
Instead of #57. |
|
CI fails in Kinetic. What's the intention of melodic-devel? should it build on both melodic and kinetic, or is melodic alone okay? If kinetic is also required for this branch, I can substitute std::thread for boost::thread... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you like this version, the node version can be substituted by calling the nodelet, so that the code isn't duplicated (like here: https://www.clearpathrobotics.com/assets/guides/ros/Nodelet%20Everything.html#and-now-code ).