-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Enable Smart Placement for Workers with Assets #18395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GregBrimble
merged 3 commits into
production
from
enable-smart-placement-workers-assets
Nov 25, 2024
Merged
Enable Smart Placement for Workers with Assets #18395
GregBrimble
merged 3 commits into
production
from
enable-smart-placement-workers-assets
Nov 25, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarmenPopoviciu
approved these changes
Nov 25, 2024
WillTaylorDev
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Smart Placement docs we should explain that if you turn on smart placement then assets still served close to eyeball
Deploying cloudflare-docs with
|
Latest commit: |
bbd358d
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f6b209ee.cloudflare-docs-7ou.pages.dev |
Branch Preview URL: | https://enable-smart-placement-worke.cloudflare-docs-7ou.pages.dev |
irvinebroque
approved these changes
Nov 25, 2024
Co-authored-by: Brendan Irvine-Broque <[email protected]>
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Enable Smart Placement for Workers with Assets * Add note on Smart Placement docs about asset serving * Update src/content/docs/workers/configuration/smart-placement.mdx Co-authored-by: Brendan Irvine-Broque <[email protected]> --------- Co-authored-by: Brendan Irvine-Broque <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It is now possible to enable Smart Placement and Workers with Assets.
Documentation checklist