apps: use host header if authority unset during request handling #2101
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Host header can be used as an alternative to :authority in HTTP/3 request. However, such requests is not handled properly in Http3Conn::build_h3_response() as only authority is considered, which can cause a crash due to unwrapping. Fix this by using host header value. Note that this is only the case if authority is null or unset. In other cases, authority is preferred, either if host is also set or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host header can be used as an alternative to :authority in HTTP/3 request. However, such requests is not handled properly in Http3Conn::build_h3_response() as only authority is considered, which can cause a crash due to unwrapping.
Fix this by using host header value. Note that this is only the case if authority is null or unset. In other cases, authority is preferred, either if host is also set or not.