Use longer packet number length encoding when necessary #2181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I understand, this will mean we never use 1-byte encoding? It's not necessarily a huge issue, but I also don't really think it's the correct fix... |
|
Thanks @ghedo for the review. We still use 1-byte encoding for packet numbers between base+1 and base+126; the change makes the encoding one bit longer, not one byte longer. |
ghedo
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decoding method described in RFC 9000 treats the encoded packet number as a signed integer. We need to encode the sign bit to ensure correct decoding when 128+ packets are lost.
This PR fixes the packet number length computation, and adds a test to verify that the returned packet length is sufficient to decode the next packet number assuming a loss of 1..254 packets.
Fixes #2180