Convert to use nats-binary blob #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: the actual blob has already been added to CI in commit b73ce7e |
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
geofffranks
force-pushed
the
nats-binary
branch
2 times, most recently
from
cfdbd53 to
b32d3ea
Compare
maxmoehl
reviewed
Apr 2, 2025
|
Things are looking good testing on our end. I'll wait to merge until y'all have a chance to test as well though. |
maxmoehl
previously approved these changes
Apr 3, 2025
There was a problem hiding this comment.
Approving as the change in general is fine.
We still have to decide how to fix the tests, either we somehow know the version in the tests and fetch the binary from GH / blobstore as well or we keep the module for now but that will probably start to drift soon.
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
ameowlia
approved these changes
Apr 3, 2025
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts from source to binary blob so we can pull in CVE fixes before they're post-embargo.
Backward Compatibility
Breaking Change? no