feat(facetBar): prevent rendering accordion for empty facets #23
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The programming language facet was accidentally removed because I had read the requirements to remove the facet completely. However, Hour of Code should still have the programming language facet. - Added a check to the FacetBar component to ensure that accordions are not rendered when there are no facet values. - Re-add programming language facet
stephenliang
force-pushed
the
stephen/hide-facet-dropdown
branch
from
b8a205f to
2ecb46e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The programming language facet was accidentally removed because I had read the requirements to remove the facet completely. However, Hour of Code should still have the programming language facet.
Hour of AI (No programming language facet)
Hour of Code (Programming language facet)