Step5-3 : TUNA, YM - 객체지향 프로그래밍 개선 #129
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename getCommandArrayByRegexp to getCmdList
인자 개수로 1개 초과 나올 경우 즉시 종료 후 프로그램 다시 실행
외부 변수에 접근하지 않고 객체를 인자로 받을 수 있도록 변경
상수 99999 제거 후, max 값과 min 값으로 random 넘버 생성
async function to update objcet
add the Promise function to delay the function
add cmdArr, commandParser, utils, instruction, customException module Obejct
Instruction 생성 시 utils, customException 객체 생성 되도록 추가
생성자에서 max 값과 min 값을 받을 수 있도록 수정
prototype pattern to class
let to const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STEP 5-3 : MIgration ES6 Classes and add undo, redo methods
참가자
TUNA, YM
개선 내용
prototype pattern을 class로 바꾼 후, undo와 redo 메서드를 추가