Skip to content

ui: fix raylib log message formatting by handing va_list arguments #35561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Jun 15, 2025

This PR fixes the Raylib trace log callback so that log messages are properly formatted with their arguments, rather than displaying the raw format strings.

Example Output

Before:

raylib: Loading texture: %s (%dx%d)
raylib: Failed to load image: %s

After:

raylib: Loading texture: player.png (64x64)
raylib: Failed to load image: missing_asset.png

Testing:

✅ Tested on PC
✅ Tested on device

@github-actions github-actions bot added the ui label Jun 15, 2025
@deanlee deanlee force-pushed the pyui_format_string branch 6 times, most recently from d98b41c to 0761207 Compare June 15, 2025 11:10
@deanlee deanlee force-pushed the pyui_format_string branch from 0761207 to 0fb8bfd Compare June 15, 2025 11:22
@deanlee deanlee marked this pull request as draft June 16, 2025 00:25
@deanlee deanlee force-pushed the pyui_format_string branch from 85985ad to 03fb399 Compare June 16, 2025 01:13
@deanlee deanlee force-pushed the pyui_format_string branch from 03fb399 to ba4a729 Compare June 16, 2025 01:17
@deanlee deanlee marked this pull request as ready for review June 16, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants